[webkit-reviews] review requested: [Bug 85221] [chromium] DomStorage events handling needs TLC (2) : [Attachment 142825] events3-again

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 18 17:18:46 PDT 2012


Michael Nordman <michaeln at google.com> has asked  for review:
Bug 85221: [chromium] DomStorage events handling needs TLC (2)
https://bugs.webkit.org/show_bug.cgi?id=85221

Attachment 142825: events3-again
https://bugs.webkit.org/attachment.cgi?id=142825&action=review

------- Additional Comments from Michael Nordman <michaeln at google.com>
Let's try this one again. The original patch got reverted because it made for
spectacular crash fest, see
http://code.google.com/p/chromium/issues/detail?id=127919 for those details.

This patch very close to the original with minor of differences to avoid
crashing the crash described in the crbug. The critical difference is to not
create a page's sessionStorage object while iterating in the 'find' method.


More information about the webkit-reviews mailing list