[webkit-reviews] review granted: [Bug 86122] IndexedDB: Index key paths that yield invalid keys should not fail an add/put : [Attachment 142814] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 86122: IndexedDB: Index key paths that yield invalid keys should not fail
an add/put
https://bugs.webkit.org/show_bug.cgi?id=86122

Attachment 142814: Patch
https://bugs.webkit.org/attachment.cgi?id=142814&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142814&action=review


> Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:289
> +	       indexKeys.append(PassRefPtr<IDBKey>());

Nit: Should this be using a IDBKey::create function?  Creating a PassRefPtr
explicitly feels weird.