[webkit-reviews] review denied: [Bug 86893] [Chromium] Call canAccelerate2dCanvas directly : [Attachment 142781] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 86893: [Chromium] Call canAccelerate2dCanvas directly
https://bugs.webkit.org/show_bug.cgi?id=86893

Attachment 142781: Patch
https://bugs.webkit.org/attachment.cgi?id=142781&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142781&action=review


> Source/WebCore/platform/GPUSupport.h:39
> +class GPUSupport {
> +public:
> +    static bool canAccelerate2dCanvas();
> +};

This feels much too weird to me to put in a cross-platform place.  The only
caller is guarded by PLATFORM(CHROMIUM) so we should keep the implementation in
chromium-specific locations.