[webkit-reviews] review granted: [Bug 86887] [chromium] remove obsolete WebViewClient::startDragging version : [Attachment 142769] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted jochen at chromium.org's request for
review:
Bug 86887: [chromium] remove obsolete WebViewClient::startDragging version
https://bugs.webkit.org/show_bug.cgi?id=86887

Attachment 142769: Patch
https://bugs.webkit.org/attachment.cgi?id=142769&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142769&action=review


> Source/WebKit/chromium/DEPS:35
> -  'chromium_rev': '136942'
> +  'chromium_rev': '137932'

We had trouble with rolling the chromium_rev in a previous bug.  Please makes
sure this compiles before landing.

> Source/WebKit/chromium/public/WebViewClient.h:253
> +    virtual void startDragging(WebFrame*, const WebDragData&,
WebDragOperationsMask, const WebImage&, const WebPoint&) { }

I'd leave the dragImageOffset name in since that's not obvious (at least to
me).