[webkit-reviews] review denied: [Bug 86860] KURL returns port equals to 0 if default port for protocol is in use : [Attachment 142761] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 18 12:20:06 PDT 2012


Adam Barth <abarth at webkit.org> has denied Thiago Marcos P. Santos
<tmpsantos at gmail.com>'s request for review:
Bug 86860: KURL returns port equals to 0 if default port for protocol is in use
https://bugs.webkit.org/show_bug.cgi?id=86860

Attachment 142761: Patch
https://bugs.webkit.org/attachment.cgi?id=142761&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Wouldn't it be easier to leave the internal representation as 0 and just change
SecurityOrigin::port to look up the default port if the port number is zero?

Also, 0 isn't a valid port, so there's no need to keep around an extra bit.


More information about the webkit-reviews mailing list