[webkit-reviews] review granted: [Bug 86152] The order of background-origin and background-clip is wrong in background shorthand : [Attachment 141717] Patch-Updated
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 18 12:06:06 PDT 2012
Ryosuke Niwa <rniwa at webkit.org> has granted Joe Thomas
<joethomas at motorola.com>'s request for review:
Bug 86152: The order of background-origin and background-clip is wrong in
background shorthand
https://bugs.webkit.org/show_bug.cgi?id=86152
Attachment 141717: Patch-Updated
https://bugs.webkit.org/attachment.cgi?id=141717&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141717&action=review
This looks landable. As for round-trip tests, we should probably create a
generic one that tests all CSS properties (in a separate bug/patch of course).
> LayoutTests/fast/backgrounds/background-clip-background-origin-order.html:9
> + description("Bug 86152 - The order of background-origin and background-clip
is wrong in background shorthand");
We don't normally use one-space indentation. Please outdent or use 4-spaces.
More information about the webkit-reviews
mailing list