[webkit-reviews] review denied: [Bug 77520] [WK2] Modify parameters of willSubmitForm callback : [Attachment 142700] moved to WKBundle

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 77520: [WK2] Modify parameters of willSubmitForm callback
https://bugs.webkit.org/show_bug.cgi?id=77520

Attachment 142700: moved to WKBundle
https://bugs.webkit.org/attachment.cgi?id=142700&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=142700&action=review


> Source/WebKit2/Shared/APIClientTraits.cpp:68
> -    offsetof(WKBundlePageFormClient, willSendSubmitEvent),
> +    offsetof(WKBundlePageFormClient, willSubmitForm),
>      sizeof(WKBundlePageFormClient)
>  };

This part is wrong. You can't remove the version 0 offset and replace it.
Instead, you need to add a new version with the right offset.