[webkit-reviews] review requested: [Bug 85364] [EFL] Enable Web Intents : [Attachment 142737] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <christophe.dumez at intel.com> has asked  for review:
Bug 85364: [EFL] Enable Web Intents
https://bugs.webkit.org/show_bug.cgi?id=85364

Attachment 142737: Patch
https://bugs.webkit.org/attachment.cgi?id=142737&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
What's in the patch:
- Add missing implementation for JSIntentConstructor::constructJSIntent() in JS
bindings.
- Fix compilation errors in EFL intents code (missing header includes)
- Enable Web Intents by default on EFL port
- Fix crash in ewk_intent_request_new() due to using a PassRefPtr after it
becomes null.
- Unskip webintents/web-intents-api.html

Important note:
-The following asserts fail in webintents/web-intents-obj-constructor.html even
though the constructor is fully implemented:
   * shouldNotThrow("new
WebKitIntent({'action':'a','type':'b','service':'url://a url'})");
   * shouldNotThrow("new
WebKitIntent({'action':'a','type':'b','service':'htttp://a url'})");

My code is throwing a SYNTAX_ERR because KURL(KURL(), 'url://a url').isValid()
returns false. I'm guessing the Chromium port is using a different KURL
implementation which behaves slightly differently for this case? Any advice on
how to proceed?