[webkit-reviews] review granted: [Bug 86694] Implement DOM_KEY_LOCATION_LEFT and RIGHT of KeyboardEvent's location property : [Attachment 142640] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 86694: Implement DOM_KEY_LOCATION_LEFT and RIGHT of KeyboardEvent's
location property
https://bugs.webkit.org/show_bug.cgi?id=86694

Attachment 142640: Patch
https://bugs.webkit.org/attachment.cgi?id=142640&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142640&action=review


> Source/WebCore/dom/KeyboardEvent.cpp:74
> +static inline int keyLocationCode(const PlatformKeyboardEvent& key)

You changed the returned value to int, not to KeyboardEvent::KeyLocationCode.
Is there something preventing you from using the latter?