[webkit-reviews] review granted: [Bug 86819] [chromium] Support mobile device rotation resizing : [Attachment 142653] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Alexandre Elias
<aelias at chromium.org>'s request for review:
Bug 86819: [chromium] Support mobile device rotation resizing
https://bugs.webkit.org/show_bug.cgi?id=86819

Attachment 142653: Patch
https://bugs.webkit.org/attachment.cgi?id=142653&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142653&action=review


This looks reasonable, but I'm not an expert on such things.  Is there someone
else you'd like to review your patch as well?

> Source/WebKit/chromium/src/WebViewImpl.cpp:1350
> +	   int dpiIndependentViewportWidth = newSize.width /
> +	       page()->settings()->defaultDeviceScaleFactor();
> +	   settings()->setLayoutFallbackWidth(
> +	       std::max(kStandardFallbackWidth, dpiIndependentViewportWidth));

There's no 80 col limit in WebKit. These can each be on one line.