[webkit-reviews] review denied: [Bug 86602] [Forms] Refactor HTMLFormCollection : [Attachment 142472] updated patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Rakesh <rakesh.kn at motorola.com>'s
request for review:
Bug 86602: [Forms] Refactor HTMLFormCollection
https://bugs.webkit.org/show_bug.cgi?id=86602

Attachment 142472: updated patch
https://bugs.webkit.org/attachment.cgi?id=142472&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142472&action=review


> Source/WebCore/dom/Node.h:588
> +    const Vector<FormAssociatedElement*>* formControlElements();
> +    const Vector<HTMLImageElement*>* formImageElements();
> +    unsigned numberOfFormControlElements();
> +

I don't think Node should have them. If you'd like to have common ways to get
them in HTMLCollection, you should define these function like:
  static unsigned numberOfFormControlElements(HTMLElement* base);

> Source/WebCore/html/HTMLFormElement.h:162
> -    Vector<FormAssociatedElement*> m_associatedElements;
> -    Vector<HTMLImageElement*> m_imageElements;
> +    mutable OwnPtr<Vector<FormAssociatedElement*> > m_associatedElements;
> +    mutable OwnPtr<Vector<HTMLImageElement*> > m_imageElements;

Why do you need to change them to OwnPtr<>?

In general, ChangeLog entry should explain reasons of the change.