[webkit-reviews] review requested: [Bug 75119] MediaElementAudioSourceNode should support multi-channel > stereo : [Attachment 142608] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 17 20:00:13 PDT 2012
Wei James <james.wei at intel.com> has asked for review:
Bug 75119: MediaElementAudioSourceNode should support multi-channel > stereo
https://bugs.webkit.org/show_bug.cgi?id=75119
Attachment 142608: Patch
https://bugs.webkit.org/attachment.cgi?id=142608&action=review
------- Additional Comments from Wei James <james.wei at intel.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=142608&action=review
>> Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp:71
>> + if (!numberOfChannels || numberOfChannels >
AudioContext::maxNumberOfChannels() \
>
> style nit: Please remove continuation character '\' and leave everything on
one long line
fixed. thanks. Just back from chromium coding style. :)
More information about the webkit-reviews
mailing list