[webkit-reviews] review granted: [Bug 86522] [Chromium] Store HTTP version in WebURLResponse : [Attachment 142583] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Ami Fischman
<fischman at chromium.org>'s request for review:
Bug 86522: [Chromium] Store HTTP version in WebURLResponse
https://bugs.webkit.org/show_bug.cgi?id=86522

Attachment 142583: Patch
https://bugs.webkit.org/attachment.cgi?id=142583&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142583&action=review


> Source/Platform/chromium/public/WebURLResponse.h:53
> +    enum HTTPVersion { Unknown, HTTP_0_9, HTTP_1_0, HTTP_1_1 };

Why no HTTP_2_0 ?  :)

> Source/WebCore/platform/network/chromium/ResourceResponse.h:39
> +	   enum HTTPVersion { Unknown, HTTP_0_9, HTTP_1_0, HTTP_1_1 };

I'd add a FIXME about moving this enum to ResourceResponseBase and implementing
it for other ports.