[webkit-reviews] review denied: [Bug 86390] Expose document-relative caret rect via window.internals : [Attachment 142297] Patch (with change from comment 8)

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Shezan Baig
<shezbaig.wk at gmail.com>'s request for review:
Bug 86390: Expose document-relative caret rect via window.internals
https://bugs.webkit.org/show_bug.cgi?id=86390

Attachment 142297: Patch (with change from comment 8)
https://bugs.webkit.org/attachment.cgi?id=142297&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=142297&action=review


>> Source/WebCore/testing/Internals.cpp:421
>> +	}
> 
> Can't we just use localToAbsolute or its friends here?

Yes we totally should. We also have FrameSelection::absoluteCaretBounds() which
does this already.