[webkit-reviews] review granted: [Bug 86778] Linux amd64 platform reported as i686 : [Attachment 142570] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 17 15:56:27 PDT 2012


Tony Chang <tony at chromium.org> has granted Michael Moss <mmoss at chromium.org>'s
request for review:
Bug 86778: Linux amd64 platform reported as i686
https://bugs.webkit.org/show_bug.cgi?id=86778

Attachment 142570: Patch
https://bugs.webkit.org/attachment.cgi?id=142570&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142570&action=review


LGTM.  I'll wait for the ews bots to go green before setting cq+.

> Source/WebCore/ChangeLog:7
> +	   http://code.google.com/p/chromium/issues/detail?id=128167
> +
> +	   Reviewed by NOBODY (OOPS!).

Nit: You could add some text here about this code pre-dating the code in
WebCore to detect this at runtime.


More information about the webkit-reviews mailing list