[webkit-reviews] review granted: [Bug 86739] background-size specified by a single value in background shorthand fails to parse : [Attachment 142539] ProposedPatch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted  review:
Bug 86739: background-size specified by a single value in background shorthand
fails to parse
https://bugs.webkit.org/show_bug.cgi?id=86739

Attachment 142539: ProposedPatch
https://bugs.webkit.org/attachment.cgi?id=142539&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142539&action=review


>>> Source/WebCore/css/CSSParser.cpp:3394
>>>	     // For backwards compatibility we set the second value to the
first if it is omitted.
>> 
>> It looks like the comment here is trying to handle this case.  Should we be
hitting this code instead?
> 
> There is another comment down which says that we just need to do it for
-webkit-background-size and not for background-size. So I thought it's better
to keep it as it is. Please let me know if I need to change this.

Ah, you're right, that's just for -webkit-background-size.  Your code looks
correct.