[webkit-reviews] review granted: [Bug 86774] Add more descriptive warnings for framebuffer incomplete conditions : [Attachment 142555] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 17 14:45:29 PDT 2012


Kenneth Russell <kbr at google.com> has granted Gregg Tavares <gman at google.com>'s
request for review:
Bug 86774: Add more descriptive warnings for framebuffer incomplete conditions
https://bugs.webkit.org/show_bug.cgi?id=86774

Attachment 142555: Patch
https://bugs.webkit.org/attachment.cgi?id=142555&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Looks good. I was going to comment that using String& rather than const char**
might be "cleaner", but realized that you don't want to have any const char* ->
String conversion overhead when calling around in the common case. r=me


More information about the webkit-reviews mailing list