[webkit-reviews] review granted: [Bug 83321] Text tracks should not render unless they have kind=captions or kind=subtitles : [Attachment 138879] Remove any currently rendered cues if kind changes to a non-visible kind. + tests.

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Anna Cavender
<annacc at chromium.org>'s request for review:
Bug 83321: Text tracks should not render unless they have kind=captions or
kind=subtitles
https://bugs.webkit.org/show_bug.cgi?id=83321

Attachment 138879: Remove any currently rendered cues if kind changes to a
non-visible kind.  + tests.
https://bugs.webkit.org/attachment.cgi?id=138879&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=138879&action=review


> Source/WebCore/html/HTMLMediaElement.cpp:1288
> +	   ExceptionCode unusedException;
> +	   track->setMode(TextTrack::HIDDEN, unusedException);

ASSERT_NO_EXCEPTION would be preferable.

> Source/WebCore/html/track/TextTrackCue.cpp:614
> +    ExceptionCode unusedException;
> +    m_displayTree->remove(unusedException);

Ditto.