[webkit-reviews] review granted: [Bug 86671] Standalone table-columns should be wrapped in anonymous tables : [Attachment 142537] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Levi Weintraub
<leviw at chromium.org>'s request for review:
Bug 86671: Standalone table-columns should be wrapped in anonymous tables
https://bugs.webkit.org/show_bug.cgi?id=86671

Attachment 142537: Patch
https://bugs.webkit.org/attachment.cgi?id=142537&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142537&action=review


r=me with some changes.

> LayoutTests/ChangeLog:11
> +	   * fast/table/table-column-generates-anonymous-table-expected.html:
Added.
> +	   * fast/table/table-column-generates-anonymous-table.html: Added.

As mentioned, I would like a test for the column-group case as I don't think
it's properly covered.

> LayoutTests/ChangeLog:17
> +	   * platform/chromium-linux/fast/forms/form-hides-table-expected.txt:
Added. An anonymous
> +	   table is now generated to enclose the misparented table column.
> +	   *
platform/chromium-linux/fast/table/form-with-table-style-expected.txt: Added.
> +	   *
platform/chromium-linux/fast/table/form-with-table-style-expected.png:
Modified. The
> +	   expectations previously were wrong in that the table column occupied
height the
> +	   equivalent of its line-height. This is correctly no longer the case.


These tests should be skipped on the other platforms or the bots will be sad.