[webkit-reviews] review granted: [Bug 85799] IconDatabase: Move icon retain/release off of the main thread. : [Attachment 142104] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 17 13:07:46 PDT 2012


Brady Eidson <beidson at apple.com> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 85799: IconDatabase: Move icon retain/release off of the main thread.
https://bugs.webkit.org/show_bug.cgi?id=85799

Attachment 142104: Patch
https://bugs.webkit.org/attachment.cgi?id=142104&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=142104&action=review


> Source/WebCore/loader/icon/IconDatabase.cpp:1513
> +
> +    // NOTE: The caller is assumed to hold m_urlAndIconLock.
> +

In the past I thought we had a way to ASSERT this.

Do we still?


More information about the webkit-reviews mailing list