[webkit-reviews] review requested: [Bug 86051] [chromium] Scale all compositor output by the defaultDeviceScaleFactor : [Attachment 142533] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 17 12:51:19 PDT 2012


Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 86051: [chromium] Scale all compositor output by the
defaultDeviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=86051

Attachment 142533: Patch
https://bugs.webkit.org/attachment.cgi?id=142533&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
Removed the pageScaleFactor from NCCH. It called
deviceOrPageScaleFactorChanged() whenever its viewport is set, as it did
before.

Doing this from WebViewImpl instead doesn't buy us anything really.. we should
do in order:
1. change the deviceScaleFactor() reported from the NCCH
2. report the change to the GraphicsLayer
3. change the size of the GraphicsLayer

1 and 3 happen in NCCH::setViewport, so it's simplest to do 2 there as well.
Else we have to add API to make 1 happen from WebViewImpl separately.


More information about the webkit-reviews mailing list