[webkit-reviews] review canceled: [Bug 86749] add skia test_expectations override file to chromium NRWT : [Attachment 142531] Patch

[bugzilla-daemon at webkit.org]

Elliot Poger <epoger at chromium.org> has canceled Elliot Poger
<epoger at chromium.org>'s request for review:
Bug 86749: add skia test_expectations override file to chromium NRWT
https://bugs.webkit.org/show_bug.cgi?id=86749

Attachment 142531: Patch
https://bugs.webkit.org/attachment.cgi?id=142531&action=review

------- Additional Comments from Elliot Poger <epoger at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142531&action=review


> Tools/Scripts/webkitpy/layout_tests/port/chromium.py:328
>	   if builder_name != 'DUMMY_BUILDER_NAME' and not '(deps)' in
builder_name and not builder_name in self.try_builder_names:

This patch handles the new skia test_expectations file exactly the same as the
chromium test_expectations file (only is observed on certain builders, etc.)

Given the comments in https://bugs.webkit.org/show_bug.cgi?id=86749 , I think
it actually makes more sense to handle the skia test_expectations file a bit
differently... so I will be uploading a second patch to this same bug soon. 
Then we can decide which approach is better...

So, no need to review this patch until the next one shows up.