[webkit-reviews] review denied: [Bug 86385] animatedType regression : [Attachment 142494] Accumulate SVG animations into first contributing element

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Philip Rogers
<pdr at google.com>'s request for review:
Bug 86385: animatedType regression
https://bugs.webkit.org/show_bug.cgi?id=86385

Attachment 142494: Accumulate SVG animations into first contributing element
https://bugs.webkit.org/attachment.cgi?id=142494&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Code changes look good, but this should get tested more. Ideally your crash
test turns into a reftest, then we can also verify the animation works as
expected.
Ideally you'll also add a test using the JS sampling framework
(runAnimationTest), to sample eg. the 'cx' value at 0.099s, 0.1s, 0.1001s to
make sure the transition between those animations works as expected. There
should be plenty of examples on how to create a test for this (just use the new
style tests which load a .svg file from svg/animations/resources/foo.svg, embed
it into svg/animations/foo.html, and test it via
svg/animation/script-tests/foo.svg