[webkit-reviews] review requested: [Bug 61862] EventSource should support CORS : [Attachment 142495] patch 6
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 17 10:14:11 PDT 2012
Per-Erik Brodin <per-erik.brodin at ericsson.com> has asked for review:
Bug 61862: EventSource should support CORS
https://bugs.webkit.org/show_bug.cgi?id=61862
Attachment 142495: patch 6
https://bugs.webkit.org/attachment.cgi?id=142495&action=review
------- Additional Comments from Per-Erik Brodin <per-erik.brodin at ericsson.com>
Updated patch:
- The constructor bindings are now generated (this wasn't possible until
recently)
- Added testing of the new second argument to the constructor
- addConsoleMessage now used instead of addMessage (it doesn't output a line
number anymore)
- didFail is now called from ThreadableLoaderClient in case
didFailAccessControlCheck is not overridden
- Fixed EventSource.h indentation
More information about the webkit-reviews
mailing list