[webkit-reviews] review granted: [Bug 86648] WebKit2: Make PluginInfoStore properly thread-safe. : [Attachment 142293] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 86648: WebKit2: Make PluginInfoStore properly thread-safe.
https://bugs.webkit.org/show_bug.cgi?id=86648

Attachment 142293: Patch
https://bugs.webkit.org/attachment.cgi?id=142293&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=142293&action=review


> Source/WebKit2/UIProcess/Plugins/PluginInfoStore.cpp:79
> +static inline Vector<PluginModuleInfo> deepCopyPluginInfoVector(const
Vector<PluginModuleInfo>& vector)
> +{
> +    // Let the copy begin!
> +    Vector<PluginModuleInfo> copy;
> +    for (unsigned i = 0; i < vector.size(); ++i)
> +	   copy.append(vector[i].isolatedCopy());
> +    return copy;
> +}

I think this function needs the word isolated in its title.

Would be nice to do a reserveCapacity here so we get a vector of the right size
instead of a larger one.