[webkit-reviews] review granted: [Bug 86732] Web Inspector: speed-up markQueriableHeapObjects function. : [Attachment 142474] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 86732: Web Inspector: speed-up markQueriableHeapObjects function.
https://bugs.webkit.org/show_bug.cgi?id=86732

Attachment 142474: Patch
https://bugs.webkit.org/attachment.cgi?id=142474&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142474&action=review


> Source/WebCore/inspector/front-end/HeapSnapshot.js:-1180
> -		   list.push(iter.edge.node.nodeIndex);

Please revert this part.

> Source/WebCore/inspector/front-end/HeapSnapshot.js:1197
> +			    ? nodes[nodeIndex + firstEdgeIndexOffset +
nodeFieldCount]

Please realign these two lines.

> Source/WebCore/inspector/front-end/HeapSnapshot.js:1213
> +	   this._flags = new Uint32Array(this.nodeCount);

Does it make any difference?