[webkit-reviews] review requested: [Bug 71271] [Qt] Web Inspector: local inspector client UI becomes unresponsive on debugger pause during : [Attachment 142441] Patch

[bugzilla-daemon at webkit.org]

Tsarko Yaroslav <eriktsarko at googlemail.com> has asked  for review:
Bug 71271: [Qt] Web Inspector: local inspector client UI becomes unresponsive
on debugger pause during
https://bugs.webkit.org/show_bug.cgi?id=71271

Attachment 142441: Patch
https://bugs.webkit.org/attachment.cgi?id=142441&action=review

------- Additional Comments from Tsarko Yaroslav <eriktsarko at googlemail.com>
Greetings everyone!

After 3 days of debugging JavaScript debugger in QtWebkit I have found the
reason of Web Inspector GUI lock when debuggee page was paused. The reason
itself is quite trivial: Web Inspector front-end (also written in JavaScript)
was also paused along with the debuggee page itself. I suppose that this bug
has been introduced by commit a2ce7739 (qtwebkit repo) when every QWebPage
being created was explicitly added to PageGroup called "Default Group". When
debugger pauses page it also pauses all the pages that belong to its page
group. So the Web Inspector page was paused too. The applied patch fixes this
problem (I`ve tested it with Qt 4.8.1 with QtWebkit 2.2.2).