[webkit-reviews] review denied: [Bug 86266] 5/10/12 update to Snow Leopard and Lion breaks Webview form input fields : [Attachment 142380] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Beth Dakin <bdakin at apple.com>'s request for review:
Bug 86266: 5/10/12 update to Snow Leopard and Lion breaks Webview form input
fields
https://bugs.webkit.org/show_bug.cgi?id=86266

Attachment 142380: Patch
https://bugs.webkit.org/attachment.cgi?id=142380&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=142380&action=review


> Source/WebCore/ChangeLog:4
> +	   5/10/12 update to Snow Leopard and Lion breaks Webview form input
fields

Please use either the subversion revision where this bug was introduced (it
might be a revision committed to a branch) or at the very least the Safari
version number where the bug first appeared (5.1.6).

> Source/WebCore/ChangeLog:15
> +	   5/10/12 update. Un-styled text fields will still use NSTextFieldCell
on these 

Again, please just refer to revision numbers or Safari versions.

> Source/WebCore/rendering/RenderThemeMac.mm:737
> -    bool useNewGradient = true;
> +    bool useNSTextFieldCell = true;

This variable is now only used in an interesting way in Lion and Snow Leopard,
so it shouldn’t exist in the common code.

> Source/WebCore/rendering/RenderThemeMac.mm:751
> +    // We do not use NSTextFieldCell to draw styled text fields on Lion and
SnowLeopard because
> +    // there are a number of bugs on those platforms that require
NSTextFieldCell to be in charge
> +    // of painting its own background. We need WebCore to paint styled
backgrounds, so we'll use
> +    // this WebCoreSystemInterface function instead.
> +    if (!useNSTextFieldCell) {
> +	   wkDrawBezeledTextFieldCell(r, isEnabled(o) &&
!isReadOnlyControl(o));
> +	   return false;
> +    }

This code is also specific to Lion and Snow Leopard, so it should be in the #if
block for those platforms.

> Source/WebCore/rendering/RenderThemeMac.mm:753
> +    NSTextFieldCell* textField = this->textField();

Star on the wrong side of the space.