[webkit-reviews] review denied: [Bug 86691] Simplify syntax in test_expectations.txt : [Attachment 142408] Simplifies the syntax

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 16 21:43:24 PDT 2012


Dirk Pranke <dpranke at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 86691: Simplify syntax in test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=86691

Attachment 142408: Simplifies the syntax
https://bugs.webkit.org/attachment.cgi?id=142408&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
Okay, I've skimmed through the patch but not looked at it in detail. I wish you
had waited until there was some sort of consensus before working on this :(

It seems like Dimitri feels roughly the same way that I do; it's not clear to
me that this is a big improvement over the existing code. Also, he's right that
we should change the output of the failures from NRWT so that you can copy and
paste them in. 

I'm R-'ing this for now just to avoid any confusion while we can come to an
agreement on what the syntax should be. If we do decide that the syntax you've
implemented is what we want, I'll go back and do a proper review of it.


More information about the webkit-reviews mailing list