[webkit-reviews] review denied: [Bug 86522] [Chromium] Store HTTP version in WebURLResponse : [Attachment 142335] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Ami Fischman
<fischman at chromium.org>'s request for review:
Bug 86522: [Chromium] Store HTTP version in WebURLResponse
https://bugs.webkit.org/show_bug.cgi?id=86522

Attachment 142335: Patch
https://bugs.webkit.org/attachment.cgi?id=142335&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142335&action=review


> Source/WebCore/platform/network/chromium/ResourceResponse.h:47
> +	       : m_httpVersion(WebKit::WebURLResponse::Unknown)

Yeah, we block including from Platform/chromium/public so that we don't leak
these API concepts to the rest of WebCore.  In particular, this line isn't
correct because only things inside WebCore/platform are allowed to know about
the API.

Instead, you should create a WebCore/platform/network abstraction for
HTTPVersion.  That way when we expand HTTPVersion to be used by other ports, we
won't have Chromium-specific API types messing us up.