[webkit-reviews] review denied: [Bug 86603] Memory leak in NetworkInfoClient : [Attachment 142213] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 16 20:16:12 PDT 2012
Adam Barth <abarth at webkit.org> has denied Sudarsana Nagineni (babu)
<naginenis at gmail.com>'s request for review:
Bug 86603: Memory leak in NetworkInfoClient
https://bugs.webkit.org/show_bug.cgi?id=86603
Attachment 142213: Patch
https://bugs.webkit.org/attachment.cgi?id=142213&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Thanks for the patch, but this isn't the normal idiom we use for managing the
lifetime of clients. Take a look at how some of the other clients work, such
as the Geolocation clients. It's better if we're consistent in how we handle
these sorts of objects.
More information about the webkit-reviews
mailing list