[webkit-reviews] review granted: [Bug 73802] [Qt] REGRESSION(101967): It made editing/style/iframe-onload-crash-mac.html timeout : [Attachment 142382] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 73802: [Qt] REGRESSION(101967): It made
editing/style/iframe-onload-crash-mac.html timeout
https://bugs.webkit.org/show_bug.cgi?id=73802

Attachment 142382: Patch
https://bugs.webkit.org/attachment.cgi?id=142382&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142382&action=review


> Source/WebCore/editing/ApplyStyleCommand.cpp:995
> +	       Node* child = currentChildren.at(i).get();

Please do currentChildren[i].get(); instead.

> Source/WebCore/editing/ApplyStyleCommand.cpp:996
> +	       if (!child->parentNode())

We could go with an even stricter check like child->parentNode() != current.