[webkit-reviews] review granted: [Bug 70833] SerializedScriptValue: lazy initialization of static nullValue not threadsafe : [Attachment 140363] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Joshua Bell
<jsbell at chromium.org>'s request for review:
Bug 70833: SerializedScriptValue: lazy initialization of static nullValue not
threadsafe
https://bugs.webkit.org/show_bug.cgi?id=70833

Attachment 140363: Patch
https://bugs.webkit.org/attachment.cgi?id=140363&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
Let me r+ it based on the following observations:

1. "I followed up with Vitaly - he doesn't recall any performance reason for
the caching."
2. booleanValue() and numberValue() are not caching the values.

If there were any performance concern, it would be best to cache the value in
V8BindingsPerIsolateData (You can access V8BindingsPerIsolateData just by
isolate->GetData()).