[webkit-reviews] review requested: [Bug 86654] [chromium] Clear the m_private pointer when destroying WebFilterOperations to avoid assert in WebPrivateOwnPtr : [Attachment 142330] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 16 13:21:14 PDT 2012


Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 86654: [chromium] Clear the m_private pointer when destroying
WebFilterOperations to avoid assert in WebPrivateOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=86654

Attachment 142330: Patch
https://bugs.webkit.org/attachment.cgi?id=142330&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
K made reset() public. Dropping clear() since it's redundant then.

Adding private destroy() to clear the m_private pointer so that
toFilterOperations() can remain const.


More information about the webkit-reviews mailing list