[webkit-reviews] review denied: [Bug 86557] Allow WebTextFieldDecoratorClient to see applied decorations. : [Attachment 142294] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Garrett Casto
<gcasto at chromium.org>'s request for review:
Bug 86557: Allow WebTextFieldDecoratorClient to see applied decorations.
https://bugs.webkit.org/show_bug.cgi?id=86557

Attachment 142294: Patch
https://bugs.webkit.org/attachment.cgi?id=142294&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142294&action=review


> Source/WebCore/html/shadow/TextFieldDecorationElement.cpp:143
> +    if (inlineStyle()->getPropertyValue(CSSPropertyVisibility) == "hidden"
> +	   || inputStyle->visibility() == HIDDEN)
> +	   style->setVisibility(HIDDEN);

If you need this code, something has gone horribly wrong.

> Source/WebKit/chromium/public/WebStyledElement.h:32
> +#define WebStyledElement_h

As I mentioned before, it's not the right approach. Exposing StyledElement in
WebKit API is an overkill for this solution.

Perhaps instead we could morph the API to be a list of decorators in a
document?

Then, we can listen to normal document events and react to them by iterating
through the decorators and operating on them. In other words, instead of
exposing WebStyledElement, expose the WebTextFieldDecorator? WDYT?