[webkit-reviews] review granted: [Bug 86514] [chromium] KeyPad flag not set for plugin input events : [Attachment 142086] Patch w/ lint fixed
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 16 11:00:06 PDT 2012
Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Brett Wilson
(Google) <brettw at chromium.org>'s request for review:
Bug 86514: [chromium] KeyPad flag not set for plugin input events
https://bugs.webkit.org/show_bug.cgi?id=86514
Attachment 142086: Patch w/ lint fixed
https://bugs.webkit.org/attachment.cgi?id=142086&action=review
------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142086&action=review
Other than weird include order, r=me.
>> Source/WebKit/chromium/tests/WebInputEventFactoryTestGtk.cpp:37
>> +#include "KeyboardEvent.h"
>
> Alphabetical sorting problem. [build/include_order] [4]
I agree with style elf.
More information about the webkit-reviews
mailing list