[webkit-reviews] review denied: [Bug 82875] Pressing Return at the bottom of an enclosed contenteditable div makes scrolling to jump : [Attachment 141456] Added a text for the textarea case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 16 10:13:54 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 82875: Pressing Return at the bottom of an enclosed contenteditable div
makes scrolling to jump
https://bugs.webkit.org/show_bug.cgi?id=82875

Attachment 141456: Added a text for the textarea case
https://bugs.webkit.org/attachment.cgi?id=141456&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141456&action=review


> Source/WebCore/editing/Editor.cpp:948
> +    bool alignToEdge = isEndOfDocument(caret);

Calling isEndOfDocument here is wrong.


More information about the webkit-reviews mailing list