[webkit-reviews] review denied: [Bug 86602] [Forms] Refactor HTMLFormCollection : [Attachment 142214] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 16 09:46:41 PDT 2012


Alexey Proskuryakov <ap at webkit.org> has denied Rakesh
<rakesh.kn at motorola.com>'s request for review:
Bug 86602: [Forms] Refactor HTMLFormCollection
https://bugs.webkit.org/show_bug.cgi?id=86602

Attachment 142214: proposed patch
https://bugs.webkit.org/attachment.cgi?id=142214&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142214&action=review


Marking r- due to build breakage.

> Source/WebCore/html/HTMLFormCollection.h:38
> -    static PassOwnPtr<HTMLFormCollection> create(HTMLFormElement*);
> +    static PassOwnPtr<HTMLFormCollection> create(Node*);

Why does this take a Node, not an Element?


More information about the webkit-reviews mailing list