[webkit-reviews] review denied: [Bug 86621] Web Inspector: Copy ... actions in the context menu don't work in the remote debugging mode. : [Attachment 142270] Comments addressed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 16 08:50:35 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 86621: Web Inspector: Copy ... actions in the context menu don't work in
the remote debugging mode.
https://bugs.webkit.org/show_bug.cgi?id=86621

Attachment 142270: Comments addressed
https://bugs.webkit.org/attachment.cgi?id=142270&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142270&action=review


> Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js:116
> +	   if (!this._textToCopy)

I still don't understand what is happening here...

> Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js:195
> +function clipboardAccessDeniedMessage() {

{ on the next line. You should not declare top-level functions.


More information about the webkit-reviews mailing list