[webkit-reviews] review granted: [Bug 86632] Web Inspector: Support script snippets saving. : [Attachment 142264] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 16 08:39:56 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 86632: Web Inspector: Support script snippets saving.
https://bugs.webkit.org/show_bug.cgi?id=86632

Attachment 142264: Patch
https://bugs.webkit.org/attachment.cgi?id=142264&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142264&action=review


> Source/WebCore/inspector/front-end/ScriptSnippetModel.js:299
> +    * @param {WebInspector.ContentProvider} contentProvider

Wrong indent.

> Source/WebCore/inspector/front-end/ScriptSnippetModel.js:323
> +	       callback();

Why conditional?


More information about the webkit-reviews mailing list