[webkit-reviews] review granted: [Bug 86566] [V8] Pass Isolate to convertEventTargetToV8Object() : [Attachment 142140] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 16 08:34:25 PDT 2012
Nate Chapin <japhet at chromium.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 86566: [V8] Pass Isolate to convertEventTargetToV8Object()
https://bugs.webkit.org/show_bug.cgi?id=86566
Attachment 142140: Patch
https://bugs.webkit.org/attachment.cgi?id=142140&action=review
------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142140&action=review
> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:3830
> - return "V8DOMWrapper::convertEventTargetToV8Object($value)";
> + return "V8DOMWrapper::convertEventTargetToV8Object($value,
$getIsolate)";
Does this need a bindings/scripts/test change?
More information about the webkit-reviews
mailing list