[webkit-reviews] review granted: [Bug 86617] Web Inspector: [Extensions API] expose evaluateOptions in audit formatters : [Attachment 142242] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 86617: Web Inspector: [Extensions API] expose evaluateOptions in audit
formatters
https://bugs.webkit.org/show_bug.cgi?id=86617

Attachment 142242: Patch
https://bugs.webkit.org/attachment.cgi?id=142242&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142242&action=review


> Source/WebCore/inspector/front-end/AuditFormatters.js:32
> + * @param {*} value

Could you whitelist the types?

> Source/WebCore/inspector/front-end/AuditFormatters.js:69
> + */

Please do not declare properties on WebInspector.

> Source/WebCore/inspector/front-end/AuditFormatters.js:72
> +    if (Array.isArray(value)) 

value instanceof Array

> Source/WebCore/inspector/front-end/ExtensionAuditCategory.js:34
> + * @param {*} id

* ?

> Source/WebCore/inspector/front-end/ExtensionAuditCategory.js:72
> + * @param {function(WebInspector.AuditRuleResult):*} callback

no need to declare :*