[webkit-reviews] review denied: [Bug 86621] Web Inspector: Copy ... actions in the context menu don't work in the remote debugging mode. : [Attachment 142250] Comments addressed

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 86621: Web Inspector: Copy ... actions in the context menu don't work in
the remote debugging mode.
https://bugs.webkit.org/show_bug.cgi?id=86621

Attachment 142250: Comments addressed
https://bugs.webkit.org/attachment.cgi?id=142250&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142250&action=review


> Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js:114
> +    documentCopy: function(event)

Why do you override this document's copy?

>> Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js:205
>> +	p.textContent = WebInspector.UIString("You need to install the \"Chrome
Developer Tools Frontend\" Chrome extension.");
> 
> Since this code is in WebCore, it probably shouldn't be referring to specific
products (in this case, Chrome)?

This code should be in WebKit/chromium/src/js/DevTools.js. Who is going to own
this extension? Could it be more generic (i.e. "Clipboard access enabler"?) Or
we could combine it with the Chrome extension used for filesystem persistence.
I would not want to see a separate "Chrome Developer Tools Front-end" as an
extension.