[webkit-reviews] review granted: [Bug 83254] [EFL] Support for Battery Status API on the WebKit-Efl : [Attachment 140671] Update patch for building on efl ews.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 16 06:19:08 PDT 2012


Chang Shu <cshu at webkit.org> has granted Kihong Kwon <kihong.kwon at samsung.com>'s
request for review:
Bug 83254: [EFL] Support for Battery Status API on the WebKit-Efl
https://bugs.webkit.org/show_bug.cgi?id=83254

Attachment 140671: Update patch for building on efl ews.
https://bugs.webkit.org/attachment.cgi?id=140671&action=review

------- Additional Comments from Chang Shu <cshu at webkit.org>
Kihong explained that it's ok not to include tests in this patch offline:
"This patch is intended to be working for laptop or mobile device which has
battery.
Therefore, it doesn't seem to right to create specific test cases for the
desktop purposes as desktop PC doesn't run on battery, generally speaking.

For example, blackberry implemented this patch without having specific test
cases - https://bugs.webkit.org/show_bug.cgi?id=82615.
IMO, this would have not be a problem if I originally included this code in
my previous work, the main battery status API
(https://bugs.webkit.org/show_bug.cgi?id=62698)."

I think it's good to go.


More information about the webkit-reviews mailing list