[webkit-reviews] review granted: [Bug 86601] Web Inspector: get rid of UISourceCodeListChanged event. : [Attachment 142220] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 86601: Web Inspector: get rid of UISourceCodeListChanged event.
https://bugs.webkit.org/show_bug.cgi?id=86601

Attachment 142220: Patch
https://bugs.webkit.org/attachment.cgi?id=142220&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142220&action=review


> Source/WebCore/inspector/front-end/NavigatorView.js:-147
> -	   if (!added)

This two lines are still needed here.

> Source/WebCore/inspector/front-end/ResourceScriptMapping.js:167
> +	   var scriptIds = [];

Please remove this unused array here and in the method above.

> LayoutTests/inspector/debugger/scripts-panel-expected.txt:33
> +  source.js

A script in Content scripts tab looks weird.