[webkit-reviews] review granted: [Bug 86604] Web Inspector: Move edit/save script source logic to JavaScriptSource. : [Attachment 142223] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 86604: Web Inspector: Move edit/save script source logic to
JavaScriptSource.
https://bugs.webkit.org/show_bug.cgi?id=86604

Attachment 142223: Patch
https://bugs.webkit.org/attachment.cgi?id=142223&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142223&action=review


> Source/WebCore/inspector/front-end/DebuggerResourceBinding.js:47
>  WebInspector.DebuggerResourceBinding.canEditScriptSource =
function(uiSourceCode)

Thsi method should no longer exist.

> Source/WebCore/inspector/front-end/JavaScriptSource.js:172
> +	   return
WebInspector.DebuggerResourceBinding.canEditScriptSource(this) &&
this._isEditable;

just inline it.

> Source/WebCore/inspector/front-end/NavigatorView.js:59
> +    this._boundUISourceCodeWorkingCopyChanged =
this._uiSourceCodeWorkingCopyChanged.bind(this);

You don't have to bind methods for removing them, just use the "listener,
this)" notation.

> Source/WebCore/inspector/front-end/TabbedEditorContainer.js:67
> +    this._boundUISourceCodeWorkingCopyChanged =
this._uiSourceCodeWorkingCopyChanged.bind(this);

ditto