[webkit-reviews] review denied: [Bug 80509] OOM running webgl/sdk/tests/conformance/context/context-creation-and-destruction.html : [Attachment 140422] Patch

[bugzilla-daemon at webkit.org]

Alejandro G. Castro <alex at igalia.com> has denied Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 80509: OOM running
webgl/sdk/tests/conformance/context/context-creation-and-destruction.html
https://bugs.webkit.org/show_bug.cgi?id=80509

Attachment 140422: Patch
https://bugs.webkit.org/attachment.cgi?id=140422&action=review

------- Additional Comments from Alejandro G. Castro <alex at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=140422&action=review


Looks good to me :), thanks. It fixes the issue reported.

> Source/WebCore/platform/graphics/cairo/GLContext.h:33
> +    static PassOwnPtr<GLContext> createContextForWindow(uint64_t
windowHandle, GLContext* sharingContext);

Is there a situation where we do not want to use the static shared context or
we can create a new one?

> Source/WebCore/platform/graphics/glx/GLContextGLX.cpp:96
> +
> +

Nit: two lines.