[webkit-reviews] review requested: [Bug 86591] [Refactoring] Move platform-specific code in Editor::respondToChangedSelection to the WebKit layer : [Attachment 142188] The proposed solution 1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 16 01:28:50 PDT 2012
Hironori Bono <hbono at chromium.org> has asked for review:
Bug 86591: [Refactoring] Move platform-specific code in
Editor::respondToChangedSelection to the WebKit layer
https://bugs.webkit.org/show_bug.cgi?id=86591
Attachment 142188: The proposed solution 1
https://bugs.webkit.org/attachment.cgi?id=142188&action=review
------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings,
I have written a change that adds a virtual function
TextCheckerClient::shouldEraseMarkersAfterChangeSelection to remove these
#if,..,#endif blocks. I would like to set r? to try this change on EWS bots to
check if they can compile this change. (I have verified I can compile this
change on Chromium, Mac, Win, and Qt, though.)
Regards,
Hironori Bono
More information about the webkit-reviews
mailing list