[webkit-reviews] review denied: [Bug 84251] [shadow] needs style recalculation by changing applyAuthorStyles dynamically : [Attachment 141647] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 84251: [shadow] needs style recalculation by changing applyAuthorStyles
dynamically
https://bugs.webkit.org/show_bug.cgi?id=84251

Attachment 141647: Patch
https://bugs.webkit.org/attachment.cgi?id=141647&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=141647&action=review


In addition to reftests, It would be desired to check style value using
widow.getComputedStyle()
before and after the second change. That allows you to ensure that the value is
actually changed dynamically.

> Source/WebCore/dom/ShadowRoot.cpp:201
> +	       owner()->needsStyleRecalc();

needsStyleRecalc() doesn't have any side effect.
It looks what you want is setNeedsReattachHostChildrenAndShadow().

> LayoutTests/fast/dom/shadow/shadow-root-applyAuthorStyles.html:94
> +    shadowRoot.applyAuthorStyles = true;

You need to force layout here (using offsetLeft or getComputedStyle like thing)


> LayoutTests/fast/dom/shadow/shadow-root-applyAuthorStyles.html:108
> +    shadowRoot.applyAuthorStyles = false;

Ditto.