[webkit-reviews] review granted: [Bug 83610] AudioParam must support fan-in (multiple audio connections) : [Attachment 142120] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 83610: AudioParam must support fan-in (multiple audio connections)
https://bugs.webkit.org/show_bug.cgi?id=83610

Attachment 142120: Patch
https://bugs.webkit.org/attachment.cgi?id=142120&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=142120&action=review


Looks good to me overall. Couple of minor comments.

> LayoutTests/webaudio/audioparam-connect-audioratesignal.html:92
> +    gainNode.gain.value = 0;

Is this change really related to this patch? If not, I suggest splitting it
out. If so, will existing Web Audio apps need to be updated?

> LayoutTests/webaudio/audioparam-summingjunction.html:97
> +    // Create 2st buffer used to control gain (a simple sine wave tone).

2st -> 2nd